Refine places display #2581
Refine places display #2581
Conversation
...will be replaced by streamlined activity creation soon
we now just return all places and filter in components
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
==========================================
+ Coverage 76.76% 77.57% +0.80%
==========================================
Files 359 354 -5
Lines 37010 36126 -884
Branches 1825 1793 -32
==========================================
- Hits 28410 28023 -387
+ Misses 8600 8103 -497
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Since I now treat 'archived' as yet another status, maybe it's too easy to see archived stores? But I would leave it and see if users tell us... |
|
Great! I think it's a really nice improvement :) Elevating places... A few things off the top of my head before diving into the code: Would be nice to be able to click the whole box, like in the group gallery. Maybe can include the place image (the random stuff) in the card? ... and I imagine one day we will have place images. Add to favourites from the card?
When there are no activities, or favourite icon, the whitespace looks a bit spacious, could a) make it collapse when there is no "status" row, b) move the status things to the bottom of the card, c) something else, d) nothing.
Could not show "Unspecified" as the place type if that's the value set... sort of special case...
I would go for a + button on the top toolbar, rather than this offer-style plus button (I think the offers page would be better off with that too)... so we move towards a more consistent UI/UX.... and I think the + button is better, or, more likely to be able to be standard....
I think these would look better aligned left, rather than justified. At least that's how they are on the activities page. Filters on the left, buttons on the right. Here I am stuck in the middle with you. Oops went off piste there. Something funny happens with the activity counts. Looking at the network tab, I think the intention is to fetch activity list with page size of 1200, and do the counts from there. Sometimes it does that, sometimes it loads 10 at a time (and makes lots of requests). And the number in the UI flashes from a low number to a high number... so not sure what's going on. Maybe two things are fighting to set the page size (the page size isn't part of the query key, so I think that is quite likely to be the case somewhere...). One idea would be to include it as part of the place status data, to add an I wonder if for some groups it becomes harder to find the places, as they are no longer in a big list to compare... I guess we can find out... I wondered at some point if using the QTable component could be a good standard, as it has a grid style mode too --> https://quasar.dev/vue-components/table#grid-style ... and then could offer users the choice of which view they prefer. Again, not needed for now, unless motivation went that way... |
| @@ -183,7 +183,7 @@ export default { | |||
| return { opacity: this.showOverlay ? 0.5 : 1 } | |||
| }, | |||
| placesWithLocation () { | |||
| return this.places.filter(hasLocation) | |||
| return this.places.filter(place => place.status === 'active').filter(hasLocation) | |||
There was a problem hiding this comment.
Ah yeah, I notice now the sidenav map doesn't keep up to date with the filtered places in the list...
There was a problem hiding this comment.
I kind of ignored the sidenav map... I guess it could also just show the subscribed places, but then it would also be nice to show all places on demand. Leave it for now?
|
Coming back to this :) I think I addressed most of the points you mentioned, here are the others:
I couldn't figure out a nice design that doesn't take too much space.. also, the
I left it in to have one special case less, maybe it's a motivation to set custom place types ;) |
Branch deployment URL: https://refine-places-display.dev.karrot.world
Add a new "place gallery" page to have a nice display of all places with additional information. The sidenav place list will only contain favorite places that users marked themselves (with the 'star' button on the place page).
Code-wise, I refactored a bit, mostly by merging three components
SidenavPlaces,SidenavPlacesUIandPlaceList. Hence quite some removed lines in the PR.New place gallery
gallery.webm
Closes #2559