Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to public activity listing UI #2621

Merged
merged 3 commits into from Dec 12, 2022

Conversation

nicksellen
Copy link
Member

@nicksellen nicksellen commented Dec 11, 2022

Fixes #2602

What does this PR do?

  • "upcoming activities" heading
  • show the activity type name on first line
  • date on second
  • a horiztonal line to divide the activity info from the activity description

publicactivities2

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #karrot:matrix.org
  • added an entry to CHANGELOG.md (description, pull request link, username(s))
  • tried out on a mobile device (does everything work as expected on a smaller screen?)

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #2621 (63040c1) into master (fb3beef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
+ Coverage   76.82%   76.84%   +0.01%     
==========================================
  Files         376      376              
  Lines       39933    39957      +24     
  Branches     1976     1976              
==========================================
+ Hits        30679    30703      +24     
  Misses       9254     9254              
Impacted Files Coverage Δ
src/groupInfo/pages/GroupPreview.vue 99.41% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nicksellen
Copy link
Member Author

Maybe @brnsolikyl wants to look at this design here :)

@brnsolikyl
Copy link
Contributor

Looking good! I like it!

@nicksellen
Copy link
Member Author

I improved it a bit more as well, I got bothered by the:

  • misaligned ativity type name and date text
  • cut off icon
  • dividing line that didn't cross the whole thing
  • the apply button being on the edge (there is still some oddness with how all the buttons will show up in certain cases though....

@tiltec tiltec merged commit 2454a94 into master Dec 12, 2022
@tiltec tiltec deleted the improve/public-activity-listing-ui branch December 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public activities looking weird on group preview page
3 participants