Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure absolute URL paths start with / #2623

Merged
merged 1 commit into from Dec 12, 2022
Merged

Conversation

nicksellen
Copy link
Member

Fixes #2618

What does this PR do?

The public activity link was being generated with a missing /, which sort of worked, but I think some programs didn't recognise it as a link or something. This ensures we always generate links with that / in place.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #karrot:matrix.org
  • added an entry to CHANGELOG.md (description, pull request link, username(s))
  • tried out on a mobile device (does everything work as expected on a smaller screen?)

@tiltec tiltec merged commit 48e64a6 into master Dec 12, 2022
@tiltec tiltec deleted the fix/public-activity-share-link branch December 12, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public activity share link improvement
2 participants