Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement role for allowing pickups #928

Closed
tiltec opened this issue Mar 2, 2018 · 1 comment
Closed

Implement role for allowing pickups #928

tiltec opened this issue Mar 2, 2018 · 1 comment

Comments

@tiltec
Copy link
Member

tiltec commented Mar 2, 2018

(Originally written by Nick, moved from https://github.com/yunity/karrot-backend/issues/419)

If the application has to do different things depending a users state/roles, then we can implement these roles.

This allows the frontend to implement UI based on the roles, and not re-implement the logic from the backend to decide what the user can do.

  • if a group has an active agreement set, then only users that have agreed to it should be able to do pickups
  • otherwise the user should be able to do pickups

It means more bureaucracy to manage the roles for the users (e.g. when there is no agreement all the users need to have that role, and when you add an agreement, all those roles go away), but it seems like it should be a good approach.

Related to #324 (comment)

@djahnie
Copy link
Member

djahnie commented Mar 28, 2018

We don't have a clear concept if this role is actually needed, so discussion should go back to #324
It might also be connected to #546, but requirements haven't been specified there either.

@djahnie djahnie closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants