Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files including one file too big #16

Closed
ghost opened this issue Aug 6, 2014 · 4 comments
Closed

Multiple files including one file too big #16

ghost opened this issue Aug 6, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 6, 2014

Hi,

When I select multiple files including one of them with a size too big, I get an error in the debug console : "Cannot read property 'name' of undefined". Then I don't see the error message related to the size of the file because the preview zone don't appear.

@kartik-v
Copy link
Owner

kartik-v commented Aug 7, 2014

This will require incorporating additional checks for parsing FileReader API exceptions. Am recording an enhancement for next release.

@ghost
Copy link
Author

ghost commented Aug 7, 2014

Okay thank you :)

@kartik-v
Copy link
Owner

kartik-v commented Aug 7, 2014

I would suggest in the interim - for large file size handling - use the maxFileSize property. Read about it in the documentation. You can check an example of its usage.

I will create a new enhancement request separately for the exception handling.

@kartik-v kartik-v closed this as completed Aug 7, 2014
@kartik-v
Copy link
Owner

kartik-v commented Aug 7, 2014

Check #17. Enhancements added with upgraded release v2.1.0. You can setup maxFilesCount to control the number of files which user uploads. The performance has been enhanced for loading image files for preview.

However, note if the number of files is large - then the performance or stability would depend on how the browser caches it in the client memory (since the FileReader API uses asynchronous loading). Hence to prevent any browser generated memory leaks - its recommended to tune it using the maxFilesCount property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant