Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got bootstrap is not defined in fileinput.js #1758

Closed
2 tasks done
spo0okie opened this issue Sep 21, 2021 · 2 comments
Closed
2 tasks done

got bootstrap is not defined in fileinput.js #1758

spo0okie opened this issue Sep 21, 2021 · 2 comments
Labels

Comments

@spo0okie
Copy link

spo0okie commented Sep 21, 2021

  1. upgrade bootstrap-fileinput to 5.2.6
  2. try to render page with Kartik\FileInput on it
  3. get subject failure
  4. downgrade bootstrap-fileinput to 5.2.4
  5. it works fine!
  • Google Chrome
  • Windows
  • bootstrap-fileinput version: 5.2.6

Isolating the problem

in 5.2.4 there is "window.bootstrap" usage in code where bootstrap version is detecting (in very begining of fileinput.js)
in 5.2.6 just bootstrap itself and it looks like undefined

@quasiperfect
Copy link

hi @kartik-v this is wrong. bootstrap is not polluting window anymore and if i don't include Alert in my bootstrap js your comparison failes

@kartik-v
Copy link
Owner

kartik-v commented Jan 6, 2023

Need to check if anything changed in BS lib. Irrespective.... You need the bootstrap JS Library and jquery to be loaded before the plugin JS assets. Can you check this? Will check on bootstrap lib changes to alter the code accordingly for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants