Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE10+ Huge freeze if file >3mb with preview enabled #799

Closed
2 tasks
Kiblyn11 opened this issue Nov 14, 2016 · 8 comments
Closed
2 tasks

IE10+ Huge freeze if file >3mb with preview enabled #799

Kiblyn11 opened this issue Nov 14, 2016 · 8 comments

Comments

@Kiblyn11
Copy link

Kiblyn11 commented Nov 14, 2016

I'm able to reduce the freeze time (10 sec instead of 2mn) by commenting the line 2467.
objUrl.revokeObjectURL($img.attr('src'));

Do someone know what is the impact of commenting this line ?

Steps to reproduce the issue

  1. Initialize the plugin with showPreview: true and ajaxUpload
  2. Browse and choose a file > 3mb on IE10+
  3. Observe that IE hang for about 2 minutes

Environment

Browsers

  • Internet Explorer

Operating System

  • Windows

Computer

i7, 8gb RAM

@kartik-v
Copy link
Owner

The revokeObjectUrl is supposed to actually release browser memory for the cached Blob that generates the data url for reading the file/image.

Some of these FAQs like this here and this article here explains this concept.

Would like to know if there is a JS fiddle or a code to test and reproduce and see your configuration.

@kartik-v
Copy link
Owner

kartik-v commented Nov 14, 2016

BTW... You can set showPreview to false for accelerated file selections as that will not read the file content into memory.

@Kiblyn11
Copy link
Author

Kiblyn11 commented Nov 14, 2016

The thing is, I need the preview :)
What do you think about releasing the memory asynchroniously ? --> Same result, IE freeze
To avoid freeze, as its not something we need to wait for.

Edit : Im gonna do a jsfiddle

@Kiblyn11
Copy link
Author

Here is the JsFiddle : https://jsfiddle.net/braylath/3vtqu1wa/3/
Tested with this image : http://imgur.com/a/2UdbV
Tested with : Edge, Edge IE10 document mode

Remark : Seems its only slow at the first upload (need to clean cache after to reproduce)

@kartik-v
Copy link
Owner

kartik-v commented Nov 15, 2016

I can confirm that I can see this issue specific to IE10 as described above while for other browsers (including Chrome/FF/Safari/IE 11/Edge) it seems to work fine.

Will need to check on setting options specific to this. Doing a browser specific fix is always irritating 😠 ,

@HusamAamer
Copy link

I have the same issue in Safari :(

@kstolarczyk
Copy link

Still freezing on IE 10/11

@kartik-v
Copy link
Owner

Folks this is entirely browser and your client h/w memory specific when you wish to preview large files. As an alternative disable client previews if you wish to handle large files. Initial Preview after server upload can still be shown,

Refer a stack overflow question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants