Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileimagesresized event is not triggered #825

Closed
koxu1996 opened this issue Dec 28, 2016 · 0 comments
Closed

fileimagesresized event is not triggered #825

koxu1996 opened this issue Dec 28, 2016 · 0 comments
Labels

Comments

@koxu1996
Copy link
Contributor

koxu1996 commented Dec 28, 2016

Steps to reproduce the issue

  1. Open fiddle
  2. Select multiple images (larger than 50px height) at once
  3. fileimagesresized is not fired!

What cause this

In this commit 755bab1 you change code:

var counter = {val: 0};
for (i = 0; i < self.loadedImages.length; i++) {
    ..
    // notice that counter is global, because it is passed by reference!
    .. self._getResizedImage(.., counter, ..) ..
    ..
}

to this

for (i = 0; i < self.loadedImages.length; i++) {
    ..
    .. self._getResizedImage(.., {val: 0}, ..) ..
    ..
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants