Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in examples. #164

Closed
reedHam opened this issue Apr 24, 2023 · 1 comment
Closed

Typo in examples. #164

reedHam opened this issue Apr 24, 2023 · 1 comment

Comments

@reedHam
Copy link
Contributor

reedHam commented Apr 24, 2023

Hi, thanks for your hard work.

When I was going over the docs I found some strange wording.

// We multiple response network calls in atomic callback for best performance

Also kind of confused about what is going on with the atomic response and how that could improve performance.

I'm excited to try using this webserver that actually seems to care about performance!

@kartikk221
Copy link
Owner

Hey, nice catch. Feel free to make a PR and I'll merge it for any typos.

From what the uWebsockets.js developer has mentioned about .atomic() which under the hood does a .cork() its intended use is to essentially use it when you are doing a lot of network calls in a single go but tbh I haven't really experienced any significant speed-up when using it or building it into the Response.send() handler which already makes a bunch of network calls in a single execution.

If you find out what it is supposed to help with, let me know and I'll be glad to implement changes. In regards to performance, yeah HyperExpress is pretty much the fastest webserver you'll find in the whole Node.js ecosystem that offers an Express-like experience.

You can see https://web-frameworks-benchmark.netlify.app/result?l=javascript for up to date benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants