Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP url for uWebSockets.js package #186

Closed
ndaidong opened this issue Sep 7, 2023 · 1 comment
Closed

Use HTTP url for uWebSockets.js package #186

ndaidong opened this issue Sep 7, 2023 · 1 comment

Comments

@ndaidong
Copy link

ndaidong commented Sep 7, 2023

Is it better to use HTTP url for uWebSockets.js, so it does not require git package to clone repo while installing?

Current:

{
  "dependencies": {
    "uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.31.0"
  }
}

New:

{
  "dependencies": {
    "uWebSockets.js": "https://github.com/uNetworking/uWebSockets.js/archive/refs/tags/v20.31.0.tar.gz"
  }
}

This small change will help hyper-express work better in the containers, where git maybe not available.

@kartikk221
Copy link
Owner

Hey @ndaidong This would certainly remove the need for git package to be available while installing. However, I am not sure If the URL convention for archives on GitHub will remain consistent over the future hence If GitHub was to change the archive links then package installs may break due to requesting the direct tarball URL.

With that said, If you can provide any other information that would ensure that using the direct tarball URL is as safe and stable as using the github: convention then I would be more than glad to have this change made or merge a PR from you to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants