You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @ndaidong This would certainly remove the need for git package to be available while installing. However, I am not sure If the URL convention for archives on GitHub will remain consistent over the future hence If GitHub was to change the archive links then package installs may break due to requesting the direct tarball URL.
With that said, If you can provide any other information that would ensure that using the direct tarball URL is as safe and stable as using the github: convention then I would be more than glad to have this change made or merge a PR from you to do so.
Is it better to use HTTP url for uWebSockets.js, so it does not require git package to clone repo while installing?
Current:
New:
This small change will help hyper-express work better in the containers, where git maybe not available.
The text was updated successfully, but these errors were encountered: