Request not found on '/' ended urls

[mortezaom]

Hi @kartikk221
I was working on my API and I created a router with this structure:

And when I checked the Rest Client for http://localhost:5000/api/v1 I got the response but for http://localhost:5000/api/v1/ I got "Not Found".

is there any option in hyper-express server to fix this or not?

this is my server object:

and these are the responses from the Rest Client:

[kartikk221]

Hi, the reason why http://localhost:5000/api/v1 works but http://localhost:5000/api/v1/ does not is because they are fundamentally 2 different URLs. HyperExpress does not automatically route trail slash endings of URLs to their non trail slash routes.

In this scenario, I would recommend adding code in your not found handler to redirect requests ending in trail slashes to their non trail slash counter parts.

Something like below would be a start:

server.set_not_found_handler((request, response) => {
   // Redirect requests ending in trail slashes to non trail slash URL
   if (request.path.endsWith('/')) {
      // Remove the trailing slash from the path of the URL
      const non_trail_slash_url = request.url.replace(request.path, request.path.substring(0, request.path.length - 1));

      // Redirect the request to the non trailing slash URL
      return response.redirect(non_trail_slash_url);
   }
});

[ThinhVu]

@kartikk221 Does the response.redirect send 301 status to client?
If yes, then remove trail slash before route mapping is better approach.

[kartikk221]

The Response.redirect(url) method simply sets the HTTP status code to 302 and writes a location header.

hyper-express/src/components/http/Response.js

Lines 698 to 706 in 0100dd0

	* This method is used to redirect an incoming request to a different url.
	*
	* @param {String} url Redirect URL
	* @returns {Boolean} Boolean
	*/
	redirect(url) {
	if (!this.completed) return this.status(302).header('location', url).send();
	return false;
	}

Yeah, the best approach would be to remove the trail slash before route mapping and then internally route the requests but the problem is it would be a breaking change for the current version and something that will be kept in consideration for the next major version.

[ThinhVu]

Yeah, the best approach would be to remove the trail slash before route mapping and then internally route the requests but the problem is it would be a breaking change for the current version and something that will be kept in consideration for the next major version.

I think it's better to keep the same behavior and provide an option to let the user decide whether the trail slash would be removed or not.