Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res.cookie is incompatible with express #204

Closed
dimdenGD opened this issue Nov 16, 2023 · 1 comment
Closed

res.cookie is incompatible with express #204

dimdenGD opened this issue Nov 16, 2023 · 1 comment

Comments

@dimdenGD
Copy link

dimdenGD commented Nov 16, 2023

Line:

cookie(name, value, expiry, options, sign_cookie = true) {

hyper-express: cookie(name, value, expiry, options, sign_cookie = true)
vs
express: res.cookie(name, value [, options]) http://expressjs.com/en/4x/api.html#res.cookie

Also options.expires in express accepts Date for when it should expire, while hyper-express accepts Number of milliseconds before expiry

@kartikk221
Copy link
Owner

Hi, changing the function of the Response.cookie() method would be a breaking change hence it is planned for the next major update which is in the works and will bring closer compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants