Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated example of static serving / LiveDirectory #223

Closed
benjaco opened this issue Jan 31, 2024 · 1 comment · Fixed by #225
Closed

Outdated example of static serving / LiveDirectory #223

benjaco opened this issue Jan 31, 2024 · 1 comment · Fixed by #225

Comments

@benjaco
Copy link
Contributor

benjaco commented Jan 31, 2024

The example at docs/LiveDirectory.md is outdated

The Server.get handler uses the extension property from the LiveFile class in Live Directory which issn't included in version 3 of Live Directory, latest version with this extension is Version 2

@kartikk221
Copy link
Owner

Hi, good catch. Do you want to make a PR with the fix or would you like me to make the change? I believe version 2 used to simply split by . and take the last part as the extension, possibly something similar could be done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants