Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel parsing is missing a few tags #27

Closed
kartikprabhu opened this issue Mar 24, 2014 · 4 comments
Closed

rel parsing is missing a few tags #27

kartikprabhu opened this issue Mar 24, 2014 · 4 comments
Labels

Comments

@kartikprabhu
Copy link
Owner

source: http://tommorris.org/posts/8867
mf2py: http://kylewm.com/api/mf2?url=http%3A%2F%2Ftommorris.org%2Fposts%2F8867
php-mf2: http://pin13.net/mf2/?url=http://tommorris.org/posts/8867

notice missing rel values of 'syndication', 'me' and 'home'

@kartikprabhu
Copy link
Owner Author

Found the problem! parse_rels is called only from parse_el but once a microformat is found everything happens in handle_microformat and parse_props.

So all rels inside a microformat never get added!

cc: @kylewm

@kylewm
Copy link

kylewm commented Mar 25, 2014

Ah, that makes sense. What do you think of doing 'rels' in a totally separate step, outside the regular descent parsing? Alternatively, I think parse_props is called on every node -- could throw parse_rels in there...

@kartikprabhu
Copy link
Owner Author

@kylewm No. parse_props is only called on micrformats elements, so it will miss rels on ordinary ones. Something about this tree-traversal is off. I'm temporarily moving rels to a separate traversal.

@kylewm
Copy link

kylewm commented Mar 25, 2014

woohoo thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants