This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Don't sort an empty file list #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
suggested changes
Feb 3, 2017
lib/fileParser.js
Outdated
| return sortFile(tempFiles2, cleanupList); | ||
| }).then(function (sortedFile) { | ||
| cleanupList.push(sortedFile); | ||
| return addJobsFromSortedFile(sortedFile, options, addJobCallback); | ||
| }).then(function (result) { | ||
| core.log('info', 'Finished job creation... no more unemployment... at least for a bit'); | ||
| return result; | ||
| }).catch(function() { | ||
| core.log('info', 'All tiles filtered out, nothing to process'); |
There was a problem hiding this comment.
I don't think catching and ignoring all errors is good. Its better to explicitly handle it by returning false or null, and handling it.
|
Updated. |
|
I'm a bit confused - you still throw an exception if the sort list is empty, but you handle it later too? |
sort just waits for stdin forever Closes #1 Bug: T145534
|
The check in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort just waits for stdin forever
Closes #1
Bug: T145534