Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ReorderableGridView.builder() #13

Closed
renannery opened this issue Dec 4, 2021 · 6 comments
Closed

Add support for ReorderableGridView.builder() #13

renannery opened this issue Dec 4, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@renannery
Copy link

When dealing with a large list, it can get pretty slow while scrolling.

I understand the implementation is different and quite challenging, but something to consider support for better performance.

@karvulf
Copy link
Owner

karvulf commented Dec 5, 2021

Hello @renannery

Thank you for your feedback.
I will take a look to improve the performance. I have some ideas.

@karvulf karvulf added the enhancement New feature or request label Dec 5, 2021
@karvulf
Copy link
Owner

karvulf commented Jan 22, 2022

I released a new release candidate for the version 2.0.0.
I added the implementations for all types of GridViews, including GridView.builder. This also improve the performance generally.

If you want to try that, you can use the version 2.0.0-dev.1.

@renannery

@karvulf karvulf changed the title Add support for ReorderableGridView.buider() Add support for ReorderableGridView.builder() Jan 22, 2022
@renannery
Copy link
Author

Thank you! I've just tested and apparently, the animation stopped working when items are moving position in the gridview.
In my implementation, there is no user interaction with drag-and-drop, the elements change their positions randomly according to our API and until version 1.1.5 it works just fine.

Switching to 2.0.0-dev.1 using the default constructor ReorderableGridView() the animation won't work

@karvulf
Copy link
Owner

karvulf commented Jan 29, 2022

Ah ok, this implementation is still in process.
Currently I only have rebuilt the drag and drop functionality.
The animation type is a bit more difficult, but if I am successfull, there will be another widget, that you can only use for that type of animation, sth like AnimatedReorderableGridView or both of them combined.
@renannery

@karvulf
Copy link
Owner

karvulf commented Feb 1, 2022

There is a new update for the release candidate.
I added the missing animation for all types in the GridView. For ReorderableWrap it is currently not supported.

You can test2.0.0-dev.2. There you also should have a better performance when using ReorderableGridView.builder.
@renannery

You can find more information about this update in the CHANGELOG.md.

@karvulf
Copy link
Owner

karvulf commented Feb 28, 2022

Hello @renannery
Today, I released the official version 2.0.0.
Now you have also support for GridView.builder. Check out the example too see more about that.

@karvulf karvulf closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants