Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChocolateCastle frees iconification icon in wrong method #1

Closed
tboeckel opened this issue Feb 13, 2017 · 1 comment
Closed

ChocolateCastle frees iconification icon in wrong method #1

tboeckel opened this issue Feb 13, 2017 · 1 comment
Assignees
@tboeckel
Labels
AmigaOS3 AmigaOS4 bug

Comments

@tboeckel
Copy link
Collaborator

tboeckel commented Feb 13, 2017 •
edited
Loading

According to http://www.amigans.net/modules/xforum/viewtopic.php?post_id=105942#forumpost105942 a crash happens when closing a project window. This happens, because the icon is freed for every removed code generator in the CAAM_RemoveGenerator method, even while the icon is still in use by the application. Even worse, once freed the icon pointer is NOT set to NULL so that the next invokation of the method will free it again.

Since the icon is obtained during OM_NEW it would be better to implement a dedicated OM_DISPOSE method and free the icon there and only once.
@tboeckel
Copy link
Collaborator Author

chocolatecastle_crash.txt

@tboeckel tboeckel self-assigned this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tboeckel tboeckel

Labels
AmigaOS3 AmigaOS4 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tboeckel