Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit MDHolder #32

Open
eirrgang opened this issue Apr 29, 2018 · 0 comments
Open

Revisit MDHolder #32

eirrgang opened this issue Apr 29, 2018 · 0 comments
Labels
gromacs pertains specifically to GROMACS library support. See kassonlab/gromacs-gmxapi

Comments

@eirrgang
Copy link
Collaborator

This class should probably be further simplified and maybe refactored in conjunction with an update to the Context concept on the libgromacs side. Note there are also some possibly confusing semantics and naming with the gmxapi::Workflow (not in the public interface, resembling the Python gmx.workflow.WorkSpec) and gmxapi::MDWorkSpec, which is in the public API but differs in important ways from the Python WorkSpec.

gmxapi::MDWorkSpec should probably be renamed to something more specific to its use in MDHolder and undergo some combination of generalization, minimalization, and obfuscation.

@eirrgang eirrgang added this to To do in 0.0.7.2 Jun 30, 2018
@eirrgang eirrgang moved this from To do to On deck in 0.0.7.2 Nov 1, 2018
@eirrgang eirrgang moved this from On deck to To do in 0.0.7.2 Dec 6, 2018
@eirrgang eirrgang added the gromacs pertains specifically to GROMACS library support. See kassonlab/gromacs-gmxapi label Dec 11, 2018
@eirrgang eirrgang added this to the gmxapi_workspec_0_2 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gromacs pertains specifically to GROMACS library support. See kassonlab/gromacs-gmxapi
Projects
None yet
Development

No branches or pull requests

1 participant