New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better CLI #26
Merged
Merged
Better CLI #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter.py to batch.py
it would be good to have the flac compression rate and such things as command line args, but for now I guess it's already quite some improvement, maybe I'll add that later on. |
Wow, awesome job! |
thanks :) |
sezanzeb
pushed a commit
to sezanzeb/soundconverter
that referenced
this pull request
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble with the command line interface, mostly due to missing features.
So I set up some directories containing files that should be converted with a subdirectory structure and worked on the soundconverter cli until I was able to convert them into a target directory.
added -i, -r, -Q and -o options:
furthermore:
in .gitignore was a path "src/soundconverter". This is something old and can be removed, right?