Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CLI #26

Merged
merged 11 commits into from Feb 11, 2019
Merged

Better CLI #26

merged 11 commits into from Feb 11, 2019

Conversation

sezanzeb
Copy link
Contributor

@sezanzeb sezanzeb commented Feb 9, 2019

I was having trouble with the command line interface, mostly due to missing features.

So I set up some directories containing files that should be converted with a subdirectory structure and worked on the soundconverter cli until I was able to convert them into a target directory.

added -i, -r, -Q and -o options:

  • -r goes into subdirectories
  • -i ignores files that have already been converted
  • -o specifies an output directory in which the original file structure is restored
  • -Q takes values between 0 and 5 and indicates the quality of the conversion

furthermore:

  • removed --help-gst from help since it is not used
  • added example usage to --help
  • reduced redundancy of quality numbers in ui.py with get_quality in settings.py

in .gitignore was a path "src/soundconverter". This is something old and can be removed, right?

@sezanzeb
Copy link
Contributor Author

sezanzeb commented Feb 9, 2019

it would be good to have the flac compression rate and such things as command line args, but for now I guess it's already quite some improvement, maybe I'll add that later on.

@kassoulet
Copy link
Owner

Wow, awesome job!

@kassoulet kassoulet merged commit 2012d4d into kassoulet:py3k Feb 11, 2019
@sezanzeb
Copy link
Contributor Author

sezanzeb commented Feb 11, 2019

thanks :)

sezanzeb pushed a commit to sezanzeb/soundconverter that referenced this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants