Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: old workflows still referred as required when they are updated with a different name #8527

Closed
BbolroC opened this issue Nov 29, 2023 · 4 comments
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@BbolroC
Copy link
Member

BbolroC commented Nov 29, 2023

Which feature do you think can be improved?

As part of the CI migration to GHA, #8485 is to newly add the static-checks workflows for s390x on top of x86_64. This leads to an update on the existing workflow name like: (e.g.

  • From build-checks (agent, make check)
  • To Static checks / build-checks (agent, make check, ubuntu-20.04)
    )

It was expected that the old one is renamed, but the old one still appears together with the new one in the checks status keeping its status as required, which is never triggered by any events. This prevents the PR from being merged.

There are 2 solutions for this:

  • [1st] When the PR is mergerd, to encourage other PRs open at the time of changing the settings to rebase themselves onto the main branch
  • [2nd] To mark the old ones as non-required and keep the changed settings for sometime (around a week) while letting other PRs get merged, and get the non-required checks back to required again

The 1st approach incurs unnecessary maintenance overheads while the 2nd one could have chance to get a PR which does not pass the static check merged.

Thinking that we will have a similar PR for aarch64 and ppc64le, we have to make the same efforts three times for the 1st approach while just one-week careful review is required for the 2nd one when the PRs for three architectures are ready.

This issue is raised for the collaboration of @BbolroC, @jongwu and @Amulyam24 for the 2nd approach.

When the PR for aarch64 and ppc64le is ready, I would be grateful to leave a comment here. Thanks.

Relevant Slack conversation: https://katacontainers.slack.com/archives/C879ACQ00/p1700814859695369

@BbolroC BbolroC added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Nov 29, 2023
@jongwu
Copy link
Contributor

jongwu commented Nov 30, 2023

Hi @BbolroC -, thanks for your effort for this.

Sorry for that I'm not very clear with your second solusion. What should I do to catch up it? Is there an example?

@BbolroC
Copy link
Member Author

BbolroC commented Nov 30, 2023

Hi @BbolroC -, thanks for your effort for this.

Sorry for that I'm not very clear with your second solusion. What should I do to catch up it? Is there an example?

The detailed explanation has been delivered via Slack.

What this issue wants you and @Amulyam24 to do is to post a link for your PR regarding the static checks migration for aarch64 and ppc64le when it is ready. Then the community will merge 3 PRs at the same time and go with the 2nd approach. Thanks!

@BbolroC
Copy link
Member Author

BbolroC commented Dec 4, 2023

Update: aarch64 is ready since #8545 has been incorporated into #8485

@BbolroC
Copy link
Member Author

BbolroC commented Jan 19, 2024

I am closing this because #8485 has been merged.

@BbolroC BbolroC closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
To do
Development

No branches or pull requests

2 participants