Potential fixes for the Travis CI build on 1.9.3 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * "rake test" portion of the build is broken * https://travis-ci.org/katgironpe/textile_editor_helper/builds/75128504 This change addresses the need by: * Get pull request I have submitted passing. Pull request is failing due to these issue and not any real issues with the code. kathgironpe#7
|
Looks like these fixes for travis work @katgironpe let me know if there is anything I can do help with a release of this or any future maintenance. Would gladly help out if you are busy. Thanks, |
|
@mdeering Looks good. I will merge. Thank you! |
|
You hit the wrong button? "Closed with unmerged commits" I will keep the branch around for a bit longer. |
|
@mdeering It's on master branch now. Thank you! The unit tests are run independent of the integration tests so there's a minor difference with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addresses the need by:
due to these issue and not any real issues with the code.
Fixes Deprecation Warnings for SimpleForm ~> 3.1 #7