Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review comments #4

Closed
mark-hammond opened this issue Oct 25, 2022 · 4 comments
Closed

Review comments #4

mark-hammond opened this issue Oct 25, 2022 · 4 comments

Comments

@mark-hammond
Copy link

No description provided.

@mark-hammond
Copy link
Author

  1. Could you provide the output data for the 0.1, 1, and 10 day tau_rad simulations in https://swampe.readthedocs.io/en/latest/notebooks/QuickStart.html, as well as the exact input parameters (including runtime and timestep) for an exact comparison?

@mark-hammond
Copy link
Author

  1. I suggest citing Dedalus (https://dedalus-project.org/citations/) in "Similar Tools" as an example of a Python code that can handle spherical shallow-water equations. Also the spectral GFDL FMS (https://www.gfdl.noaa.gov/idealized-spectral-models-quickstart/) is an example of another GCM that can also run in shallow-water mode, like mitGCM.

@dfm
Copy link
Contributor

dfm commented Oct 26, 2022

Adding a reference to openjournals/joss-reviews#4872 for tracking purposes.

@kathlandgren
Copy link
Owner

Thank you for your comments! Apologies for the delay in addressing them.

  1. The output data and the scripts used to generate it have been added to this folder and linked from the relevant section of QuickStart.
  2. References to these tools have been added to the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants