Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database: Minor changes/Documentation #17

Closed
garmu opened this issue Feb 5, 2015 · 2 comments
Closed

Database: Minor changes/Documentation #17

garmu opened this issue Feb 5, 2015 · 2 comments
Assignees

Comments

@garmu
Copy link
Collaborator

garmu commented Feb 5, 2015

  • Someone is going to have to document the process of getting locations into the database (basically the whole DB setup)
  • There's a ton of files in the database folder that are very vague in intent. These should be documented somewhere.
  • For example, what are the tab delimited files like location for? [DONE]
  • Some files should perhaps be renamed. For example, why is there a "371CreateTables(2).sql"? [DONE]
  • There's some SQL scripts that I'm not sure of their purpose (and this needs to be documented). Eg, 371Insert.sql.
  • Now that we've actually used the CSV files, we should perhaps document what the obscure column names all refer to.
@KatrinaHoffert
Copy link
Owner

Also need to consider how this will be built. It's currently segregated from the how we build the main site. Perhaps it should use SBT as well?

Need to consider if this program should also be tested.

Possibility: instead of a standalone program, we'll have a page of the site (ie, a controller) that performs this functionality. That is, the routing is the entry point to this program. This would make it much easier to integrate for building and testing. It wouldn't be very difficult. Just move this code into the Play code and add a controller that calls the entry point (currently Main.main(String[]), but that would be renamed). Would have to change some paths, though. The dependencies would have to be added to the SBT file.

As an aside, is the MySQL library being used? It shouldn't be, since we're using Postgres.

@KatrinaHoffert
Copy link
Owner

This is mostly done. Still need to clean unused libraries from the project and unify the build process, but this should be separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants