Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for the "markers" plugin: tooltips #2589

Closed
szarza opened this issue Sep 29, 2022 · 1 comment · Fixed by #2595
Closed

Suggestion for the "markers" plugin: tooltips #2589

szarza opened this issue Sep 29, 2022 · 1 comment · Fixed by #2595

Comments

@szarza
Copy link

szarza commented Sep 29, 2022

Wavesurfer.js version(s): 6.0.2
Browser and operating system version(s): all

First of all, congratulations on the brilliant work all of you have made.

I wanted to use the "markers" plugin but with some sort of tooltip over the labels. My skills in Javascript are very limited, and I only know "classic" Javascript. Nevertheless, it was simple for me to add a tooltip to the label and rebuild the code. I attach the diff file here as a starting point if the author wants to include or improve it.

Regards,
Samuel.

index.diff.txt

@thijstriemstra
Copy link
Contributor

@szarza this could be a nice enhancement for the markers plugin, can you open a pull request and we go from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants