Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of script tags for plugins should not be affecting initialization #895

Closed
katspaugh opened this issue Dec 13, 2016 · 4 comments
Closed
Assignees

Comments

@katspaugh
Copy link
Owner

Quoting #825:

I modified your zoom example as a codepen, to match my wavesurfer config, and at first I could not figure out why it seemed to be working on the codepen but not my site. I then realized that if I removed the regions altogether, or added them to the wavesurfer BEFORE I initialize the timeline then it works like your example. In my code, I added the regions AFTER I initialized the timeline. I am not sure if this is significant or something to note in the docs/change in the code but this seems to have fixed the problem.

Here we see how my code was set up, regions added after the timeline, and the bug I've been describing is present.
http://codepen.io/jeremylach/pen/zoWdyo?editors=1011

Solution: either make the order of scripts idempotent or add a note in the docs.

@mspae
Copy link
Contributor

mspae commented Jan 30, 2017

Will be fixed in next version through Plugin api.

@mspae mspae added the v1 label Sep 18, 2017
@thijstriemstra
Copy link
Contributor

Should be fixed in v2.0 as noted by @mspae, closing.

@heitorb
Copy link

heitorb commented Aug 23, 2018

I have 2.0.6 and I am seeing this issue. The last comment says if should be fixed in 2.0. Did anyone actually verified this fix?

@thijstriemstra
Copy link
Contributor

@heitorb any errors/logs you can share (in a new ticket)?

Repository owner locked as resolved and limited conversation to collaborators Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants