Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory limit is not checked #38

Closed
meisterT opened this issue Nov 23, 2015 · 1 comment
Closed

Memory limit is not checked #38

meisterT opened this issue Nov 23, 2015 · 1 comment

Comments

@meisterT
Copy link
Contributor

The memory limit is not applied to the submissions nor is validation_memory on validators.

Until this is fixed, I suggest to spit out a warning if a problem sets the memory limit explicitely in problem.yaml.

@austrin
Copy link
Contributor

austrin commented Feb 6, 2017

"fixed" in c671fef and b10cd30.

TL;DR: for validators, memory limit is still not applied for build/run programs. Because Java.

In particular, using rlimits to restrict memory makes the JVM very unhappy and causes it to crash on startup, so programs that might involve the JVM can not have a memory rlimit applied to it. For submissions this is not a big issue from since memory is limited by -Xmx instead, but for validators given by build/run scripts, there is no way for problemtools to know if those build/run scripts involve starting a JVM, so we can't apply a memory limit on them. In a bright and shiny future problemtools may support using cgroups to limit memory, if that is enabled on the system (or who knows, maybe the JVM will be able to boot even with memory rlimited to 1 GB), but for now, I'd like to consider this resolved.

@austrin austrin closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants