Added READ_CONTACTS permission to be able to access accounts #351
Conversation
| @@ -36,8 +36,7 @@ Licensed to the Apache Software Foundation (ASF) under one | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
| import static android.Manifest.permission.GET_ACCOUNTS; | |||
| import static android.Manifest.permission.READ_EXTERNAL_STORAGE; | |||
| import static android.Manifest.permission.*; | |||
There was a problem hiding this comment.
I'm not that versed in Android Java, but it is wise to import .*?
|
I will test your PR in Android 9 and 11 with I suppose this does work (saw here) |
| @@ -202,7 +203,16 @@ cordova.plugins.email.requestPermission(permission, callbackFn); | |||
| ``` | |||
|
|
|||
| __Note:__ The author of the app has to make sure that the permission is listed in the manifest. | |||
|
|
|||
| For __Android__ you may add the following lines to config.xml to achieve this: | |||
There was a problem hiding this comment.
this is breaking the build when I insert this in config.xml, did you mean edit-config instead?
There was a problem hiding this comment.
> Task :app:mergeDebugResources FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
> Android resource compilation failed
/home/joao/dev/form-for-parking-violation/platforms/android/app/src/main/res/xml/config.xml:97: AAPT: error: unbound prefix.
/home/joao/dev/form-for-parking-violation/platforms/android/app/src/main/res/xml/config.xml: AAPT: error: file failed to compile.
There was a problem hiding this comment.
I could make it work, it was missing xmlns:android="http://schemas.android.com/apk/res/android" at the widget root of config.xml
|
@regnete I used your PR and still when I run Furthermore it crashes while opening Email App with Android 11 If it doesn't work, we cannot merge it, sorry |
fixes #350