Version 1.14 #518
Merged
Version 1.14 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew into jira/458-travis
Saves up to 2kb of whitespace per response.
* Checking for loop_start prevents themes and plugins that pre-process shortcodes from triggering the action before displaying. Like, ahem, the Divi theme and WordPress SEO plugin * Use `include()` instead of `include_once()` to fix pre-processing issue Fixes #488
Fix theme conflicts when themes have shortcode pre-processors
Only generate the container HTML if there's a field label.
Fix empty field container
Instead of sorting by username, sort by display name, which makes a lot of sense. See https://secure.helpscout.net/conversation/116708081/3190/
- To better Gravity Forms and Gravity View loading and shutdown functions - Fix @Covers issues with local phpunit (removed the problem functions for now) - Mark any failed unit tests as incomplete (needs attention)
Conflicts: .gitignore
- Move Gravity Forms database setup after Gravity Forms is loaded
It was taking forever.
:squirrel: Don't ask.
@blueliquiddesigns Can you confirm?
Add testing - thanks @blueliquiddesigns !
Remove redundant jquery-ui close icon
This enables overriding the logic that makes sure an entry is part of a View's search results.
Previously, there were only hooks that would also possibly trigger GF actions as well.
*Major database resource and speed improvement* Affects Search Bar and GravityView Search Widgets with "Submitted by" fields, and Edit Entry screen with the Change Entry Creator. Instead of fetching `all` fields, define a limited set of fields to return. This way, they're all returned in a *single query* instead of what was happening before: a main query, then another query for each user returned. * Before: 1.6 ms query + ( .3ms * 750 users ) = 226ms; 751 queries per page load * After: 1.3 ms query; 1 query per page load Because of the speed improvements, I've increased the default # of users returned to 2000.
Override default args for get_users() query.
Otherwise, when returning from GFAPI::get_entry(), the result could be a `WP_Error`, which we don't want.
Search Bar enhancements: Search Mode & Labels
*Major database resource and speed improvement* Affects Search Bar and GravityView Search Widgets with "Submitted by" fields, and Edit Entry screen with the Change Entry Creator. Instead of fetching `all` fields, define a limited set of fields to return. This way, they're all returned in a *single query* instead of what was happening before: a main query, then another query for each user returned. * Before: 1.6 ms query + ( .3ms * 750 users ) = 226ms; 751 queries per page load * After: 1.3 ms query; 1 query per page load Because of the speed improvements, I've increased the default # of users returned to 2000.
Override default args for get_users() query.
Otherwise, when returning from GFAPI::get_entry(), the result could be a `WP_Error`, which we don't want.
Before, it was always showing the full time in 12-hour (US) format. Now, it checks the form field configuration, then displays the input-appropriate value.
We devolve into hacking SQL queries in order to get sorting by time to work with Gravity Forms. Eesh. Works nicely though, by converting values to TIME_FORMAT() and then counting their pesky seconds as necessary. Solves #492
Sort by 🕓 and display correct 🕓
I don't think it's likely anyone *wants* their display name or roles changed without warning. So, let's reset them both, then add a filter to modify the user before update.
Users receive "Password Updated" emails in WordPress 4.3+, even if the password wasn't changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task