Front-end notes #528
Merged
Front-end notes #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developed on the assumption that we can re-use Gravity Forms functionality. This may not be the case. If not, we should do AJAX notes instead, since it's nicer experience. __TODO: __ - [ ] Convert CSS to external file - [ ] Add permissions checks - [ ] Docblocks
As a power user, I would like to be able to display the entry notes in the frontend, and, if possible add more notes
|
@luistinygod Can you please test? |
# Conflicts: # includes/class-admin-views.php
I love when sites and apps support this. Like Github Desktop 👍
I did this because I wanted to use `Processing…` and it wouldn't let me use HTML in attributes. I got frustrated, and realized `<button>` is better anyway and has good support now!
Just a little. Doesn't hurt.
Instead of bold and yellow, go with a basic template others can tweak.
This might be handy in the future for more quickly fetching notes.
Things to do before merge:
|
The reality? Anyone who can do this can do this for other people's notes. This is notes, not comments.
This class is required by the JS; the <fieldset> tag is not.
At this point, the ID is hidden from the end user, and the user's already got permission to add notes to the entry
|
# Conflicts: # readme.txt
The "requires" key is the name of another checkbox in the same setting. Visibility gets toggled based on other checkbox being checked. This is very basic, but hopefully we can use something more powerful moving forward.
It's necessary to have the success message when the Entry Notes aren't being displayed; otherwise the user doesn't know whether the note has been successfully added.
Shorter!
Set a default note subject
Just in case we want to pass pure HTML into settings, this is how.
It's still necessary to wrap inputs though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed on the assumption that we can re-use Gravity Forms
functionality. This may not be the case. If not, we should do AJAX
notes instead, since it's nicer experience.
__TODO: __
┆Issue is synchronized with this Asana task