Version/1.15 #541
Merged
Version/1.15 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didn't need to be in there.
So we don't duplicate setup()
The settings weren't being merged with the default definitions, which would lead to not being created properly
Use HelpScout Beacon
Use `brew install git-archive-all`, then `brew link git-archive-all` to install using Homebrew.
Instead of having all the templates loaded in `default-templates.php`,
I moved them into their respective folders.
I also removed an unused template ("people-table")
This will be helpful for properly migrating from XML to JSON import files.
Instead of hard-coding where we expect to find the plugin. This fixes issues with unit testing.
If users didn't have `copy_gravityviews` caps, the array would be empty.
Conflicts: readme.txt
…ortcode [gv_entry_link] shortcode
Even though they're not bundled with the releases, if someone downloads from Github, that would be a problem.
Why no fail, Travis?
Added `gravityview_getting_started` capability
If users don't have the `gravityview_edit_settings`, they won't be able to save settings. If they have `gravityview_view_settings` cap, they'll be able to see them, but not edit them.
Wasn't recognizing settings page as a GravityView admin page.
{get} doesn't require GF.
`GravityView_Settings` requires `GravityView_Plugin`, which is de-activated. So instead, add a way to check for settings directly. Change `GVCommon` to `GravityView_Roles_Capabilities`, and fix path to `class-gravityview-roles-capabilities.php`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task