Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow user to choose tag for segment between kerb and sidewalk #13

Open
natedx opened this issue Jun 23, 2023 · 11 comments

Comments

@natedx
Copy link

natedx commented Jun 23, 2023

Hello @kauevestena,

First of all, what an amazing plugin ! I randomly fell upon your English demo on Youtube, and was blown away by your work !
The plugin works very well and with all the available parameters it only takes a bit of experimentation to get what you want.

The issue

In many regions the small footway segment which joins the crossing to the sidewalk is itself tagged as a sidewalk.
Example
However, in the generated crossings from SidewalKreator, this segment is always tagged as a crossing even though it is before the kerb and therefore by definition, on the sidewalk.

Possible solution

It is of course possible to edit this in JOSM later, but for the sake of speed, it would be nice to be able to choose this tagging behavior.
Adding an opt-in toggle box for this could save a lot of time.

@kauevestena
Copy link
Owner

Hey man!! I'm so thrilled that you liked it!!

Well, that's quite strange behavior according to the way it's implemented,

Can you send me an screenshot of the parameters and if don't mind a bounding box or, even better, a wkt in order for me to reproduce it and address the issue?

Sorry for the delay, I'm attending FOSS4G conference, then I'm quite focused here, but for sure I'll solve the issue!

@natedx
Copy link
Author

natedx commented Jun 29, 2023

Hello !
Sorry for the misunderstanding, SidewalkKreator is working as intended !
This is actually a feature request to implement the tagging behavior shown in my screenshot, that is the convention in my area. I will edit the title !
To rephrase, I think it would be a good idea to be able to choose the tag (crossing or sidewalk) of the small way that links the kerb to the sidewalk. In my usage, I would choose "sidewalk", but right now, SidewalKreator tags it as a "crossing". This would save me a lot of time when adjusting everything in JOSM.

As a side note, this implies that this small portion is now it's own separate way.

Here is a screenshot of my desired tagging behavior :
Capture d’écran 2023-06-29 à 12 14 32

@natedx natedx changed the title Change tag for segment between kerb and sidewalk [Feature Request] Allow user to choose tag for segment between kerb and sidewalk Jun 29, 2023
@kauevestena
Copy link
Owner

@natedx Sorry again for the delay, man, I was returning home from the conference.

Well, I'll try to implement this feature, but I'm still in a hurry with many stuff, so I'll try to address this in the next 15 days, although I found that variation of the schema quite uncanny, If it's in use is valid to be contemplated!

@kauevestena
Copy link
Owner

@natedx let me know if you still need this feature!!

@natedx
Copy link
Author

natedx commented Oct 26, 2023

Hello @kauevestena ! Yes it would be very practical ! :)

@kauevestena
Copy link
Owner

Good news, man!! I've made this test release before I implement the GUI part, test it and tell me if everything went smoothly!!

It will create the modified output in the "auxiliary_files" folder, named as "sidewalkreator_output_alt_scheme.geojson"

Enjoy!!

osm_sidewalkreator.zip

ZIP installation instructions:

plugins > manage and istall plugins... > install from ZIP

then use the "..." button to browse the file, accept the warning and the plugin should be installed!

@natedx
Copy link
Author

natedx commented Oct 30, 2023

Hello ! Just finished a test run, it seems to be working great ! Thanks a lot for the feature :)

Capture d’écran 2023-10-30 à 11 59 53

@kauevestena
Copy link
Owner

That's so nice to hear! I will package and update the QGIS plugin version!

@kauevestena
Copy link
Owner

hey @natedx do you know if this alternate schema is documented somewhere? I'm thinking of putting a checkbox on the exporting part, with a link it would be great for the user to understand.

@natedx
Copy link
Author

natedx commented Dec 19, 2023

Hello, here's what I have found on the OSM wiki : https://wiki.openstreetmap.org/wiki/Key:crossing#Additional_tags

@kauevestena
Copy link
Owner

Great, thanks a lot @natedx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants