New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial e2e-tests #26
Conversation
ee89fd1
to
61fc413
Compare
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 8 8
Lines 108 108
Branches 22 22
=======================================
Hits 107 107
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
42d62db
to
f8e18c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it cypress style to have the tests in folder cypress
? I mean, does the gh action require it? I would use e2e
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good 👍🏻 One think I think should be changed is the way to reach the tested element; so, use (for example) data-cy
instead of redundant class name :) See the comments for exact places. More information about data-cy etc.
@lauravuo I think the As it is now |
@magdapoppins if it is convention, then it is ok! |
Fixed comments + taking Lauras approval!
Fixes #17
Purpose
In addition to our unit test, let's have a set of e2e-tests that ensure that the page works and looks as expected. I chose cypress for this purpose since the NextJS docs point at it as an easy starting point.
How to test
Run
yarn cypress
and the example test.