Add deployment to GitHub pages #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauravuo
force-pushed
the
add-deployment
branch
from
11b7f41
to
f3085bd
Compare
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 97.82% 97.77% -0.05%
==========================================
Files 7 7
Lines 46 45 -1
Branches 11 11
==========================================
- Hits 45 44 -1
Partials 1 1
Continue to review full report at Codecov.
|
lauravuo
force-pushed
the
add-deployment
branch
from
56ae967
to
b83f0a3
Compare
lauravuo
force-pushed
the
add-deployment
branch
from
bd7ebf2
to
aea2842
Compare
eevajonnapanula
approved these changes
Mar 27, 2022
Comment on lines
+80
to
+84
| {/* TODO: | ||
| We skip next/image for now to be able to export fully static build. | ||
| If image optimization is needed, we can think of alternative deployment solutions. | ||
| */} | ||
| <img src="https://picsum.photos/200" alt="" width={200} height={200} /> |
There was a problem hiding this comment.
Removing the Next's Image breaks the layout, as it added some extra things to the DOM and styling, in addition to the img-tag. I can fix this later.
There was a problem hiding this comment.
Ok, good catch and sounds like a plan 🤝
| @@ -0,0 +1 @@ | |||
| almanakka.kaupunginnaiset.fi | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Closes #18
How to test
Check that CI-workflow succeeds. After merging, check that app is visible at https://almanakka.kaupunginnaiset.fi