Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoiler name in non ASCII when user in links with anchors #4

Open
stajp opened this issue Jul 24, 2013 · 1 comment
Open

Spoiler name in non ASCII when user in links with anchors #4

stajp opened this issue Jul 24, 2013 · 1 comment

Comments

@stajp
Copy link

stajp commented Jul 24, 2013

When automatic spoiler opening by anchor name is used, there is a problem with some spoiler names.

If spoiler name has a non ASCII character (eg. local letters in UTF8), all non ASCII letters are filtered when they are put as "id" of H3 element (which is open/closed) (it seems filtration is on line 1430).

Because of that, links with hash anchors look distorted eg. wpspoiler name "Čevapčići" becomes #evapii

I presume same problem is with other elements (tabs, accordion). As it's nice to use ASCII letters in links, I would propose to use additional parameter in all elements for setting "anchor/hash name".

@kavingray
Copy link
Owner

Hello @stajp , The IDs are generated from headers for the sake of simplicity and character filtration was to maximize intercompatibilty with JavaScript and hashchange. Additionally this should not be a problem with HTML5, only lesser.

Maybe it can be modified to set your own IDs or remove the filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants