Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend changes, optimization #21

Open
kawa-kokosowa opened this issue May 23, 2017 · 0 comments
Open

Frontend changes, optimization #21

kawa-kokosowa opened this issue May 23, 2017 · 0 comments

Comments

@kawa-kokosowa
Copy link
Owner

As a developer, it is very annoying that I must have a Jinja HTML snippet and jQuery of the same exact HTML for links in the filterable list view (on another note maybe there should also be a card view). Also, if someone has a ton of bookmarks this service will be incredibly slow, you need to cap off autocomplete results or allow for pagination or something?

A friend said they could help reimplent jquery to angular.

Here's a brainstorm I had earlier in irc:

jinja include

https://github.com/lily-mayfield/urlink
you see the GIF?
the search works if you don't have javascript enabled, too
i mean, it uses POST and brings you to a new page heheh
if no js
here i can show you the javascript i'm using to update the live search results
i'll state it again, an application like yours is far better implemented as a database driven application. In fact, you probably only need the javascript for ajax results. nothing else
i basically want someone who's good at frontend to tell me how horrible my way of doing things is. "my way of doing things" being my crappy jquery for updating the page on each keypress (the filter you see in GIF)
build it without js first, then enhance the experience with js to do all the ajax
i also wait for an intentional pause before submitting any results if i'm doing searches like that
react won't solve anything if you're trying to have a no-js fallback
you don't want to unintentionally ddos yourself by someone going ajsdbngaijsbdgiuabsudgbwebgajkbgkjabnsdkfjgbaskjbgakjn
https://github.com/lily-mayfield/urlink/blob/master/templates/ur_links.html#L37 this feels incredibly hard to maintain
especially since any time i update the HTML that gets sent on the page i also have to go and update the javascript
which updates the DOM
I'm thinking ideally i could just use like... a template "snippet" like jinja can include that can ALSO be templated-into the javascript, but then javascript can fill in the blanks with a formatter of some sort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants