Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for contributors related to fork repository mechanism #318

Closed
Tracked by #99
andriawan opened this issue Jul 22, 2021 · 8 comments · Fixed by #677
Closed
Tracked by #99

Add guide for contributors related to fork repository mechanism #318

andriawan opened this issue Jul 22, 2021 · 8 comments · Fixed by #677
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@andriawan
Copy link
Collaborator

to propose a change, contributors should follow guide about forking mechanism. I think we could state it in README for clarity

@fzn0x
Copy link
Contributor

fzn0x commented Jul 22, 2021

how about state it in #319 separated files?

@resir014 resir014 added the documentation Improvements or additions to documentation label Jul 22, 2021
@zainfathoni
Copy link
Member

zainfathoni commented Jul 23, 2021

@andriawan could you please track this issue and any other issues you have created inside the related epics for the sake of discoverability?

I have invited you as a Collaborator to the repository so you can edit the epic issue descriptions by yourself to do so.

Thanks, @andriawan!

@andriawan andriawan added the good first issue Good for newcomers label Jul 23, 2021
@andriawan andriawan added this to the Long-term Plan milestone Jul 23, 2021
@andriawan andriawan added this to To do in Kanban Board via automation Jul 23, 2021
@apraditya
Copy link
Contributor

@zainfathoni, now that #319 is merged & closed, is there anything else left to be done for this issue?

@andriawan
Copy link
Collaborator Author

I think it could be taken mas @apraditya

@apraditya
Copy link
Contributor

I don't quite get it @andriawan. Do you think we can close this issue?

@andriawan
Copy link
Collaborator Author

I think adding this infromation to documentation is quite important for new comer as i found several contributors is not quite familiar with forking mechanism

@zainfathoni
Copy link
Member

zainfathoni commented Aug 12, 2021

I don't quite get it @andriawan. Do you think we can close this issue?

No, he meant that you could take this issue, @apraditya. @andriawan, please try to avoid passive sentences as much as possible to avoid ambiguity. Your "it could be taken" sentence is unclear on who gets to take the issue. 😅

@adityapurwa, please create a draft pull request as explained in our contributing guidelines.

@andriawan
Copy link
Collaborator Author

sorry, i lost the context mas @zainfathoni. Sorry for my miss understanding 😅 🙏🏼 @zainfathoni @apraditya

@kodiakhq kodiakhq bot closed this as completed in #677 Aug 14, 2021
Kanban Board automation moved this from To do to Done Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

5 participants