Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size on label filters are not same with the search label #583

Closed
Tracked by #110
mazipan opened this issue Aug 7, 2021 · 10 comments
Closed
Tracked by #110

Font size on label filters are not same with the search label #583

mazipan opened this issue Aug 7, 2021 · 10 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers ui User Interface

Comments

@mazipan
Copy link
Member

mazipan commented Aug 7, 2021

Description

The font size from the labels are not consistent, the search seems have a smaller font size.

Sample page:

https://www.wargabantuwarga.com/provinces/dki-jakarta

The size for word "Cari Kontak" is not same with "Kategori" & "Lokasi"

See screenshot:

Screenshot_20210807-191232_Chrome

Expected Behaviour

I think we need to set smaller font size for the label in filters

@mazipan mazipan added bug Something isn't working good first issue Good for newcomers ui User Interface labels Aug 7, 2021
@resir014
Copy link
Member

resir014 commented Aug 7, 2021

@mazipan There's also FormLabel component, we should use it across all form elements.

https://github.com/kawalcovid19/wargabantuwarga.com/blob/main/components/ui/forms/form-label.tsx

The search box already uses it, I think the other two didn't use it

@adylanrff
Copy link

Hi, can I work on this?

@adylanrff
Copy link

adylanrff commented Aug 8, 2021

After looking at the code, I think both SearchForm and SearchFilter have already used the FormLabel component for the label. We may need to set a different font size for the SearchFilter label so that it does not seems like it is larger than the SearchForm one. What do you think?

@adylanrff
Copy link

Hi @mazipan need your input here, since the font size is actually already the same, is this issue still relevant?

@mazipan
Copy link
Member Author

mazipan commented Aug 8, 2021

Wdyt?

Screenshot_20210808-205732_Chrome

Just accessed from my Samsung A50 device, using Chrome Mobile v.92

@adylanrff
Copy link

Yeah that looks different ya,

For a comparison
IPhone 12 mini (IOS 14.7.1) using Safari

image

@mazipan
Copy link
Member Author

mazipan commented Aug 8, 2021

Arghhh, it's hard.
A spesific browser/device issue 😤

@bungandy
Copy link

bungandy commented Aug 8, 2021

Iya mas @mazipan they are fine on Chrome iOS 14 iPhone 7. Try to change the word Cari kontak -> Cari Kontak maybe? The small k character makes the word looks smaller then the other to me 😁

Chrome on iOS 14 - iPhone 7+

@adylanrff
Copy link

yeah @bungandy I thought so too, but changing Cari kontak --> Cari Kontak means changing other components that uses SearchForm component too, which may not be intended.

@mazipan
Copy link
Member Author

mazipan commented Aug 10, 2021

It should keep to use "Cari kontak".
I will close this issue for now ya 🙏

@mazipan mazipan closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ui User Interface
Projects
None yet
Development

No branches or pull requests

5 participants