Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address and Copy Button are too close #584

Closed
Tracked by #110
mazipan opened this issue Aug 8, 2021 · 6 comments
Closed
Tracked by #110

Address and Copy Button are too close #584

mazipan opened this issue Aug 8, 2021 · 6 comments
Assignees
@zainfathoni
Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right ui User Interface wontfix This will not be worked on

Comments

@mazipan
Copy link
Member

mazipan commented Aug 8, 2021

Description

Open: https://www.wargabantuwarga.com/provinces/dki-jakarta

The Address and the Copy Button are too close for some data.
I think we need to set more space between these two elements.

Screenshot_20210808-130614_Chrome

Expected Behaviour

Have enough space between copy button and the address data

Additional Information
@mazipan mazipan added bug Something isn't working good first issue Good for newcomers ui User Interface labels Aug 8, 2021
@fauzialz
Copy link

fauzialz commented Aug 8, 2021

Hello, mas. Could I work on this ticket?

@zainfathoni
Copy link
Member

Yes, please raise a draft pull request soon, @fauzialz, thanks! 🙏

@zainfathoni zainfathoni mentioned this issue Aug 8, 2021
Open
26 tasks
@fauzialz
Copy link

fauzialz commented Aug 8, 2021 •
edited

Hallo mas @zainfathoni. I checked the code and it seems that the issue has been fixed by this change #571. The changes gave 0.5rem left spacing on the copy button. I don't know if this is still a valid issue or not.

image

@fauzialz
Copy link

fauzialz commented Aug 8, 2021

I check the production app too. I think this issue is solved. cc: @mazipan

@mazipan
Copy link
Member Author

mazipan commented Aug 8, 2021

Checking it...
Since I open it before the PR merged 😂

@mazipan
Copy link
Member Author

mazipan commented Aug 8, 2021 •
edited

Ah yes, I think this is going to invalid now

Thank you for the information @fauzialz

@mazipan mazipan added invalid This doesn't seem right wontfix This will not be worked on labels Aug 8, 2021
@mazipan mazipan closed this as completed Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zainfathoni zainfathoni

Labels
bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right ui User Interface wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zainfathoni @mazipan @fauzialz