Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Access your data for all websites" permission needed? #6

Closed
Gitoffthelawn opened this issue Jan 16, 2022 · 9 comments
Closed

"Access your data for all websites" permission needed? #6

Gitoffthelawn opened this issue Jan 16, 2022 · 9 comments

Comments

@Gitoffthelawn
Copy link
Contributor

Thank you for this extension.

Is the "Access your data for all websites" really needed? If so, why?

@kawamataryo
Copy link
Owner

kawamataryo commented Jan 17, 2022

Thanks for the question!
This setting is the permissions required for the chikamichi's modal to open on all web sites.
If this is not specified, the modal will not open, as it will block the loading of content_script.js.

For a more detailed, please read to the following site

https://support.mozilla.org/en-US/questions/1299613

@Gitoffthelawn
Copy link
Contributor Author

You're welcome and thank you for the answer.

Makes sense.

Thinking aloud here...

Would it be possible/reasonable to use a toolbar popup instead of an overlay modal injected into the DOM? (I haven't reviewed the code yet, but I'm guessing that's what you are doing.)

I'm trying to brainstorm a way to have almost the same functionality without needing that big permission.

@kawamataryo
Copy link
Owner

kawamataryo commented Jan 17, 2022

Would it be possible/reasonable to use a toolbar popup instead of an overlay modal injected into the DOM? (I haven't reviewed the code yet, but I'm guessing that's what you are doing.)

I think it is possible to show history and bookmark information in popup.
However, I don't know if it is possible to ensure the same operability as now. I chose to use modal because I wanted to be able to control everything with keyboard shortcuts.

@Gitoffthelawn
Copy link
Contributor Author

Hmmm... still thinking aloud...

What about displaying content in the sidebar? I think that allows keyboard shortcuts.

@kawamataryo
Copy link
Owner

Ah.
I didn't image the popup well.
When you say "display in popup", are you thinking of something like black-menu?

https://apps.jeurissen.co/black-menu-for-google

I think it's worth a try.

@kawamataryo
Copy link
Owner

I'll consider fix it so that it shows up in a popup.

@Gitoffthelawn
Copy link
Contributor Author

Ah. I didn't image the popup well. When you say "display in popup", are you thinking of something like black-menu?

https://apps.jeurissen.co/black-menu-for-google

I think it's worth a try.

I have to experiment with that extension to see if that's similar to what I meant. Either way, my primary interest is in having the most functionality (and keeping the UX excellent) without needing the "Access your data for all websites" permission.

Also, DOM injections can get messy, cause issues, and be hard to maintain, so when possible, I think it's best to avoid that technique. That said, sometimes it is the only way to get the desired functionality.

@kawamataryo
Copy link
Owner

kawamataryo commented Jan 23, 2022

@Gitoffthelawn
Hi 👋
I made a new version.
In this version, the DOM is not injected from content script, and the form is displayed in a popup.
"Access your data for all websites" is no longer required.

#9

The release to the store is still some way off, but I think this version will resolve this issue.

@Gitoffthelawn
Copy link
Contributor Author

Wow, that's exciting! ありがとう!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants