Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks innacurate #14

Open
endel opened this issue Nov 20, 2015 · 3 comments
Open

Benchmarks innacurate #14

endel opened this issue Nov 20, 2015 · 3 comments

Comments

@endel
Copy link

endel commented Nov 20, 2015

Hey @kawanet,

That's not really an issue.

I just want to share that I've been doing some benchmarks recently, and it seems that msgpack-javascript and msgpack-js-v5 performs better in some cases.

Maybe it would be nice to have different inputs for the benchmarks in your README, since some projects may have different needs when choosing a library like this.

Congrats for your implementation, which seems really great!
Cheers

@mtth
Copy link

mtth commented Nov 29, 2015

@endel - Your benchmarks aren't doing what you think they are. You forgot to JSON.parse the data. Once you change this, msgpack-lite should perform a lot better relatively.

@endel
Copy link
Author

endel commented Nov 29, 2015

@mtth oops, you're right! I've made this change and updated the README with new results. Thanks for checking out.

I've also added the same sample used to benchmark msgpack-lite here: sample-datatypes.json - and msgpack-lite indeed stands out in this case.

@dbrgn
Copy link

dbrgn commented May 31, 2016

This can probably be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants