Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full uint32 and partial int64/uint64 support #84

Open
marcinkowskip opened this issue Mar 9, 2018 · 1 comment
Open

Full uint32 and partial int64/uint64 support #84

marcinkowskip opened this issue Mar 9, 2018 · 1 comment

Comments

@marcinkowskip
Copy link

Hello,

Great library @kawanet. I have noticed that uint32 support is limited (up to 2147483647) and int64/uint64 is not supported at all. I have prepared a patch which removes uint32 limit and adds int64/uint64 support (up to 2^53). Unfortunately, it can slow down the performance because float detection is replaced with Math.floor() function. Can you at least verify if the approach is proper?

Thanks,
PM
uint32-int64-uint64-support-added.txt

@mattbishop
Copy link

+1 for this (or similar) change. I discovered that hard way that I have to manually examine a js number and either send it to msgpack as a Uint64 or Int64 object from another library! This is the only way I can get cross-platform compatibility as other implementations treat negative numbers > 32 bits as uint64 whereas msgpack-lite treats it as an int64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants