Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecspresso run doesn't fail when ECS task failed to start #534

Closed
itkq opened this issue Mar 15, 2023 · 3 comments · Fixed by #537
Closed

ecspresso run doesn't fail when ECS task failed to start #534

itkq opened this issue Mar 15, 2023 · 3 comments · Fixed by #537

Comments

@itkq
Copy link
Contributor

itkq commented Mar 15, 2023

ecspresso run command waits for the task to exit and then looks at its status and exits with exit code 0 or 1, unless the --no-wait wait or --wait-until=running option is specified. However, if the image is invalid and cannot be pulled for example, the task will not start and the command will exit with exit code 0 because the container doesn't have exit code or reason. Is this behavior intended?

@fujiwara
Copy link
Contributor

I think espresso run should exit with non-0 status if failed to run a task. So I plan to fix the behavior.

@fujiwara
Copy link
Contributor

@itkq
Copy link
Contributor Author

itkq commented Mar 27, 2023

Thank you! It worked as expected. Looking forward to the official release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants