Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSuggestions method smells & res is undefined on exception. #14

Closed
kaskar2008 opened this issue Mar 12, 2018 · 1 comment · Fixed by #21
Closed

getSuggestions method smells & res is undefined on exception. #14

kaskar2008 opened this issue Mar 12, 2018 · 1 comment · Fixed by #21
Assignees
Labels
refactoring Code smells, needs refactoring
Projects

Comments

@kaskar2008
Copy link
Member

getSuggestions method needs to be refactored

@kaskar2008 kaskar2008 added the refactoring Code smells, needs refactoring label Mar 12, 2018
@kaskar2008 kaskar2008 added this to To do in Fixes via automation Mar 12, 2018
@lauri911
Copy link

And there is little bug as well, when "await this.list(value)" gets rejected, then variable "res" will be undefined.

@Raiondesu Raiondesu changed the title getSuggestions method getSuggestions method smells Mar 30, 2018
@Raiondesu Raiondesu changed the title getSuggestions method smells getSuggestions method smells & res is undefined on exception. Mar 30, 2018
@Raiondesu Raiondesu self-assigned this Mar 30, 2018
@Raiondesu Raiondesu moved this from To do to In progress in Fixes Mar 30, 2018
@Raiondesu Raiondesu mentioned this issue Mar 30, 2018
Merged
2 tasks
Fixes automation moved this from In progress to Done Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code smells, needs refactoring
Projects
Fixes
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants