Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress_bar_scan credit #84

Closed
daniel-dodd opened this issue Jan 5, 2023 · 1 comment · Fixed by #86
Closed

progress_bar_scan credit #84

daniel-dodd opened this issue Jan 5, 2023 · 1 comment · Fixed by #86
Assignees

Comments

@daniel-dodd
Copy link

Raising issue as part of JOSS review openjournals/joss-reviews#5021

The progress_bar_scan, i.e.,

def progress_bar_scan(num_samples, message=None):
"Progress bar for a JAX scan"
if message is None:
message = f"Running for {num_samples:,} iterations"
tqdm_bars = tqdm(range(num_samples))
tqdm_bars.set_description(message)

is seemingly adapted from this (excellent) blog post https://www.jeremiecoullon.com/2021/01/29/jax_progress_bar/

There is no problem in using this. But you should acknowledge credit to this in the decorator's docstring.

@kazewong
Copy link
Owner

kazewong commented Jan 6, 2023

Thanks for spotting this. We didn't end up using it so we will probably just take this out.

@kazewong kazewong self-assigned this Jan 17, 2023
@kazewong kazewong linked a pull request Jan 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants