Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example syntax errors. #37

Open
kazimuth opened this issue Aug 17, 2014 · 5 comments
Open

Fix example syntax errors. #37

kazimuth opened this issue Aug 17, 2014 · 5 comments

Comments

@kazimuth
Copy link
Collaborator

Many examples have syntax errors. This should be fixed.

@jdf
Copy link
Owner

jdf commented Aug 17, 2014

Depending on how the input files are structured, it shouldn't be too hard
to automate a presubmit test that checks for such errors.
On Aug 17, 2014 10:18 AM, "James Gilles" notifications@github.com wrote:

Many examples have syntax errors. This should be fixed.


Reply to this email directly or view it on GitHub
#37.

@kazimuth
Copy link
Collaborator Author

It's a little wacky - they're embedded in xml files.
We can run the build script, but a lot of things are broken in ways that aren't yet fixable, so something like travis will pretty much always say there are build errors. Do you think that would be helpful?

@kazimuth kazimuth added this to the Functional site milestone Aug 17, 2014
@jdf
Copy link
Owner

jdf commented Aug 17, 2014

I think it's always worth spending time as early as possible making things
build clean so that you can meaningfully detect problems as they happen.
On Aug 17, 2014 10:37 AM, "James Gilles" notifications@github.com wrote:

It's a little wacky - they're embedded in xml files.
We can run the build script, but a lot of things are broken in ways
that aren't yet fixable, so something like travis will pretty much always
say there are build errors. Do you think that would be helpful?


Reply to this email directly or view it on GitHub
#37 (comment)
.

@kazimuth
Copy link
Collaborator Author

Makes sense!

@aparrish
Copy link
Collaborator

I believe I caught all of the syntax errors as of #50. but the build process mentioned in this issue is still a good idea, so I'll leave open for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants