Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle problem #19

Closed
Natai opened this issue Nov 24, 2017 · 2 comments
Closed

Lifecycle problem #19

Natai opened this issue Nov 24, 2017 · 2 comments

Comments

@Natai
Copy link

Natai commented Nov 24, 2017

in your demo, just like your SimpleViewController, it's contentViewControllers call their viewDidLoad at the same time.
@kazuhiro4949
Copy link
Owner

kazuhiro4949 commented Nov 26, 2017 •
edited

Hi, @Natai .

When I modified the demo code to support iPhoneX, I added some hot-fix.
6df1f47#diff-4c11579eb36faa4b4db40f5defc65b16R31

It seems that the calling layoutIfNeeded() loads all the views.
I'll fix the problem. Thank you :)

@kazuhiro4949
Copy link
Owner

kazuhiro4949 commented Dec 1, 2017 •
edited

 I fixed this issue on the following pull-request.
#20

In addition, I solved the layout problem in another way.
https://github.com/kazuhiro4949/PagingKit/blob/61707280ac4a183b9853d2c35064ca2a1509b71d/iOS%20Sample/iOS%20Sample/ContentTableViewController.swift#L81L104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Natai @kazuhiro4949