Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To support double quote, tab, newline characters in value #8

Merged
merged 3 commits into from
Aug 25, 2017
Merged

To support double quote, tab, newline characters in value #8

merged 3 commits into from
Aug 25, 2017

Conversation

cslee
Copy link
Contributor

@cslee cslee commented Aug 24, 2017 •
edited

To handle values like below:

<i18n>
{
  "en": {
    "hello": "hello\t\"world\"!\n"
  }
}
</i18n>

kazupon
kazupon reviewed Aug 24, 2017
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Could you add test case please?

@cslee
Copy link
Contributor Author

cslee commented Aug 25, 2017

Added test cases.
Please check

@kazupon kazupon merged commit 5d51ad0 into intlify:dev Aug 25, 2017
@kazupon
Copy link
Member

kazupon commented Aug 25, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cslee @kazupon