Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped style documentation #492

Closed
scottadamsmith opened this issue Dec 21, 2018 · 3 comments
Closed

Scoped style documentation #492

scottadamsmith opened this issue Dec 21, 2018 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scottadamsmith
Copy link

scottadamsmith commented Dec 21, 2018

The Scoped style documentation might be inaccurate, unless I am misunderstanding. It indicates that when using scoped styles, you would need to use a deep selector to apply styles to the <p> in this template:

<template>
  <div class="parent">
    <p>message: {{ $t('hello') }}</p>
  </div>
</template>

When reading that, I couldn't understand why, since the <p> is part of the scope styled component and not part of the translation string. I believe this example (https://codesandbox.io/s/5vzj9lqj8n) shows that you don't need a deep selector in this scenario. Is it possible the documentation meant to describe a scenario where you are styling an HTML element that was part of the translated string?

@kazupon
Copy link
Owner

kazupon commented Jan 5, 2019

You can check the background.
#362

As you say, it should be improved the document.

@kazupon kazupon added help wanted Extra attention is needed feedback to docs good first issue Good for newcomers labels Jan 5, 2019
@IssueHuntBot
Copy link

@rororofff has funded $5.00 to this issue.


@IssueHuntBot
Copy link

@kazupon has rewarded $3.50 to @kenanchristian. See it on IssueHunt

  • 💰 Total deposit: $5.00
  • 🎉 Repository reward(20%): $1.00
  • 🔧 Service fee(10%): $0.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants