-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support right-to-left languages #26
Comments
How's it going @MajidCS . What are the symptoms you are exhibiting when using RTL other than the overlay is not on the correct side? |
I think I might know the first for this. I will probably get to it sometime in the next few days. |
A quick The problem is that indentation should also get handled properly on RTL mode (which means there would be changes on JS as well as CSS). I believe this should be added as an option to const flask = new CodeFlask;
flask.run('#editor', {language: 'javascript', rtl: true}) // add rlt functionality |
@kazzkiq That's what I was mentioning too. I might be able to write something up that includes both allowing people to select the RTL mode on runtime when running the editor and also some JS code that listens to the changes to the textarea text-align css property that changes the placeholder one as well. |
@AndreYonadam awesome! Once you move forward with the code, or if you get in any trouble, please let us know. |
Pull request #28 fixes all these features just as described. |
@AndreYonadam @kazzkiq Thanks guys |
@MajidCS Sure thing. I've been working on it but it seems that it's not producing an idea result. I'm not really familiar with how it's supposed to work but it seems like it's a limitation for all textareas when in RTL mode. Check the gif @kazzkiq has posted in #28 . We're getting mis-formatting for some reason. |
We need this mostly with Markdown thank you |
@MajidCS Wow thanks for the testing. I wasn't able to test it because I didn't know what the expected output was. Thanks again. |
PR #28 fixes this. |
Hi,
this project is cool and i want use it. but it does not support RTL language. could you pleas consider adding this feature?
For example : Bi-directional Text Demo
Thanks a lot
The text was updated successfully, but these errors were encountered: