Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help me to make it working #40

Closed
mrsof opened this issue May 26, 2017 · 8 comments
Closed

Help me to make it working #40

mrsof opened this issue May 26, 2017 · 8 comments
Labels

Comments

@mrsof
Copy link

mrsof commented May 26, 2017

Am I missing something ?

https://jsfiddle.net/MrSo/n1u0qjdd/

Thx for help

@kazzkiq
Copy link
Owner

kazzkiq commented May 27, 2017

It seems you've found a bug. There are some issues with language type while using runAll property.

I managed to fix the issue and make CodeFlask run in this example. But for some reason the style also seemed to break and make fonts misaligned.

Will have to dig this further.

@kazzkiq kazzkiq added the bug label May 27, 2017
@mrsof
Copy link
Author

mrsof commented May 27, 2017

Hmmm ok but I did not manage to make this working either...

https://jsfiddle.net/MrSo/z5vns0qh/

@ivanalemunioz
Copy link

ivanalemunioz commented May 30, 2017

@kazzkiq I managed to fix the issue in your example, see changes on CodeFlask.prototype.renderOutput function

@kazzkiq
Copy link
Owner

kazzkiq commented May 30, 2017

@ivanalemunioz Nice! Thanks, I will be incorporating the fix in the project as soon as I can.

@mrsof For some reason, the external Codeflask JS you imported seems to be buggy. That's why in my example I removed your external resource and added CodeFlask directly to the JavaScript panel.

The bad part is that by changing the external resource (using unpkg) your error vanishes, but anothe rone appears. I will have to take a look because CodeFlask seems to be breaking now.

@mrsof
Copy link
Author

mrsof commented May 30, 2017

I used links you use in your own website !
https://kazzkiq.github.io/CodeFlask.js/js/vendor/codeflask.js

Anyway, I am pleased to have contibuted to your awesome script !
Thanks

@mrsof mrsof closed this as completed May 30, 2017
@kazzkiq
Copy link
Owner

kazzkiq commented May 30, 2017

Reopening as this is a bug that must be corrected.

@kazzkiq kazzkiq reopened this May 30, 2017
@mrsof
Copy link
Author

mrsof commented May 31, 2017

Oops ok.
So maybe you should change the title.

@kazzkiq
Copy link
Owner

kazzkiq commented May 6, 2018

Using cdnjs link from 0.3.1 or jumping into 1.0 should prevent the issues in this thread.

@kazzkiq kazzkiq closed this as completed May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants